Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fmt/colors): warn that dim is incompatible accross terminals #4303

Merged
merged 3 commits into from
Feb 12, 2024
Merged

docs(fmt/colors): warn that dim is incompatible accross terminals #4303

merged 3 commits into from
Feb 12, 2024

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 requested a review from kt3k as a code owner February 11, 2024 11:46
@github-actions github-actions bot added the fmt label Feb 11, 2024
iuioiua
iuioiua reviewed Feb 11, 2024
View reviewed changes
fmt/colors.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua requested changes Feb 11, 2024
View reviewed changes
fmt/colors.ts Outdated Show resolved Hide resolved
@scarf005 @iuioiua
Update fmt/colors.ts
a1df845 
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
iuioiua approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit 94d9e5b into denoland:main Feb 12, 2024
12 checks passed
@scarf005 scarf005 deleted the fix/warn-fmt-dim branch February 12, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
fmt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fmt: warn that dim function may not work for all terminals
2 participants
@scarf005 @iuioiua