Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(front_matter): cleanup _formats.ts #4499

Merged
merged 1 commit into from
Mar 16, 2024
Merged

refactor(front_matter): cleanup _formats.ts #4499

merged 1 commit into from
Mar 16, 2024

Conversation

timreichen
Copy link
Contributor

Changes

  • renames constants in _formats.ts, uses conventional name format.
  • removes Array destructuring.
  • renames createRegExp() to createRegExps() as it returns multiple regexps.
  • removes createRegExps() spread arguments in favour of an array.

@timreichen timreichen requested a review from kt3k as a code owner March 16, 2024 09:50
kt3k
kt3k approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k changed the title chore(front_matter): cleanup _formats.ts refactor(front_matter): cleanup _formats.ts Mar 16, 2024
@kt3k kt3k merged commit 0462ce2 into denoland:main Mar 16, 2024
12 checks passed
@timreichen timreichen deleted the front_matter_rename_constants branch March 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
front-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k