Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint error in canary #4513

Merged
merged 1 commit into from
Mar 22, 2024
Merged

chore: fix lint error in canary #4513

merged 1 commit into from
Mar 22, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Future versions of Deno don't require an ignore comment around empty interfaces that extend another type. Previous Deno versions required that.

// Deno <=1.41.3
// deno-lint-ignore no-empty-interface
export interface TarEntry extends TarMetaWithLinkName {}

Canary + Future Deno versions don't need that comment.

export interface TarEntry extends TarMetaWithLinkName {}

This change to the linter in Deno was done in denoland/deno_lint#1250

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Marvin.

@marvinhagemeister marvinhagemeister merged commit 116c54a into main Mar 22, 2024
10 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-lint-error branch March 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants