-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net): getNetworkAddress()
#4677
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
+ Coverage 91.95% 91.97% +0.02%
==========================================
Files 487 488 +1
Lines 38894 38899 +5
Branches 5388 5392 +4
==========================================
+ Hits 35766 35779 +13
+ Misses 3072 3064 -8
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Sorry, my understanding of some of the IPv6 addressing was incorrect. Corrected now, and scope ID isn't needed. |
Why is the check of scopeid unnecessary?
|
* fix(net): check scopeid === 0 * tweaks * tweak --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems like a useful tool to have.