Add content-type header in fileserver #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayd
reviewed
Dec 27, 2018
ry
reviewed
Dec 31, 2018
fancyplants
pushed a commit
to fancyplants/deno_std
that referenced
this pull request
Jan 9, 2019
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43.
I took list of common mime types from MDN and extended it with
.ymland.yamlformats so I could reuse already existing tests.If extension if not recognized it falls back to
application/octet-streamwhich causes file to be downloaded by default. IMHO we could extended list more and provide it as separate module, then serve more files as plaintext instead of octet stream.