Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fs): cleanup use of @std/assert #4948

Merged
merged 7 commits into from
Jun 5, 2024
Merged

refactor(fs): cleanup use of @std/assert #4948

merged 7 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 4, 2024 •
edited
Loading

Towards #4865

@github-actions github-actions bot added the fs label Jun 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (da7b395) to head (fa8006e).

Files Patch % Lines
fs/copy.ts 35.29% 11 Missing ⚠️
fs/expand_glob.ts 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4948      +/-   ##
==========================================
- Coverage   92.17%   92.16%   -0.02%     
==========================================
  Files         487      487              
  Lines       38733    38740       +7     
  Branches     5390     5393       +3     
==========================================
  Hits        35703    35703              
- Misses       2974     2981       +7     
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 4, 2024 06:39
@iuioiua iuioiua requested a review from kt3k as a code owner June 4, 2024 06:39
kt3k
kt3k reviewed Jun 4, 2024
View reviewed changes
fs/copy.ts Outdated Show resolved Hide resolved
kt3k
kt3k reviewed Jun 4, 2024
View reviewed changes
fs/expand_glob.ts Outdated Show resolved Hide resolved
kt3k
kt3k reviewed Jun 4, 2024
View reviewed changes
fs/expand_glob.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k June 5, 2024 01:03
@iuioiua iuioiua enabled auto-merge (squash) June 5, 2024 01:20
kt3k
kt3k approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua merged commit fbfcd24 into main Jun 5, 2024
12 checks passed
@iuioiua iuioiua deleted the fs-clean-assert branch June 5, 2024 01:39
@iuioiua iuioiua mentioned this pull request Jun 5, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k