Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(async): cleanup use of @std/assert #4950

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 4, 2024

Towards #4865

@github-actions github-actions bot added the async label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (7085c94) to head (aeacdaf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4950      +/-   ##
==========================================
- Coverage   92.17%   91.78%   -0.40%     
==========================================
  Files         487      487              
  Lines       38734    38733       -1     
  Branches     5386     5356      -30     
==========================================
- Hits        35704    35550     -154     
- Misses       2974     3125     +151     
- Partials       56       58       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 4, 2024 06:38
@iuioiua iuioiua requested a review from kt3k as a code owner June 4, 2024 06:38
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) June 4, 2024 07:28
@iuioiua iuioiua merged commit da7b395 into main Jun 5, 2024
12 checks passed
@iuioiua iuioiua deleted the async-cleanup-assert branch June 5, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants