Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(path): clean isWindows logic #4972

Merged
merged 2 commits into from
Jun 5, 2024
Merged

refactor(path): clean isWindows logic #4972

merged 2 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 5, 2024

No description provided.

@iuioiua iuioiua requested a review from kt3k as a code owner June 5, 2024 07:53
@github-actions github-actions bot added the path label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (fbfcd24) to head (fb3e7b1).

Files Patch % Lines
path/_os.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4972      +/-   ##
==========================================
+ Coverage   92.16%   92.17%   +0.01%     
==========================================
  Files         487      487              
  Lines       38740    38732       -8     
  Branches     5393     5392       -1     
==========================================
- Hits        35703    35700       -3     
+ Misses       2981     2976       -5     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit cda6714 into main Jun 5, 2024
12 checks passed
@iuioiua iuioiua deleted the path-clean-isWindows branch June 5, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants