Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(csv): cleanup use of @std/assert #4976

Merged
merged 3 commits into from
Jun 5, 2024
Merged

refactor(csv): cleanup use of @std/assert #4976

merged 3 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 5, 2024

Towards #4865

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2e54f46). Learn more about missing BASE report.

Current head 053925f differs from pull request most recent head 8c27a68

Please upload reports for the commit 8c27a68 to get more accurate results.

Files Patch % Lines
csv/_io.ts 0.00% 0 Missing and 1 partial ⚠️
csv/parse.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4976   +/-   ##
=======================================
  Coverage        ?   92.15%           
=======================================
  Files           ?      487           
  Lines           ?    38739           
  Branches        ?     5395           
=======================================
  Hits            ?    35700           
  Misses          ?     2982           
  Partials        ?       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) June 5, 2024 21:54
@iuioiua iuioiua merged commit 3eec370 into main Jun 5, 2024
10 checks passed
@iuioiua iuioiua deleted the csv-clean-assert branch June 5, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants