Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(fmt): remove stripColor #5374

Merged
merged 1 commit into from
Jul 10, 2024
Merged

BREAKING(fmt): remove stripColor #5374

merged 1 commit into from
Jul 10, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jul 10, 2024

What's changed

stripColor has been replaced by stripAnsiColor in @std/fmt. No changes in behavior have been made.

Motivation

This change was made because stripAnsiColor more accurately describes the purpose of this function.

Migration guide

To migrate, use stripAnsiColor instead of stripColor.

- import { stripColor, red } from "@std/fmt/colors";
+ import { stripAnsiCode, red } from "@std/fmt/colors";

- console.log(stripColor(red("Hello, world!")));
+ console.log(stripAnsiCode(red("Hello, world!")));

@iuioiua iuioiua requested a review from kt3k as a code owner July 10, 2024 01:24
@github-actions github-actions bot added the fmt label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (0a8a338) to head (0dc3384).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5374      +/-   ##
==========================================
+ Coverage   96.32%   96.33%   +0.01%     
==========================================
  Files         458      458              
  Lines       37770    37765       -5     
  Branches     5576     5576              
==========================================
- Hits        36382    36381       -1     
+ Misses       1345     1341       -4     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d32a8c9 into main Jul 10, 2024
14 checks passed
@iuioiua iuioiua deleted the fmt-remove-stripColor branch July 10, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants