Add typecheck linter for typescript #170
Conversation
| call ale#linter#Define('typescript', { | ||
| \ 'name': 'typecheck', | ||
| \ 'executable': 'typecheck', | ||
| \ 'command': 'typecheck %s', |
There was a problem hiding this comment.
That will be running the command on the file as it is on disk, not the text you are editing as you type. You'll either need to use an option to use stdin data for the file, or use the stdin_wrapper file, probably with an argument to include the directory you are editing the file in or something similar.
There was a problem hiding this comment.
no, typecheck uses stdin by default
There was a problem hiding this comment.
Does it still use stdin if a filename is given? The '%s' here will be replaced with the filename.
There was a problem hiding this comment.
yes, typecheck needs file name to find tsconfig.json, but it will read file contents from stdin
There was a problem hiding this comment.
Ah, sounds good to me, then. Sounds similar to the --stdin-filename option for eslint, but as a positional argument.
| for l:line in a:lines | ||
| let l:match = matchlist(l:line, l:pattern) | ||
| echom len(l:match) | ||
| echom join(l:match, ", ") |
|
I think this is good. I'll let Travis CI look at this. We might find that it could be a bit slow, but it's certainly better than nothing. If it delays other checks, you can always turn it off. If someone can implement something using HTTP and the test server, I'd also accept that. |
Solves #20
typecheckts-type-checker(https://www.npmjs.com/package/ts-type-checker)It uses my simple wrapper around typescript compiler .
npm i -g ts-type-checkerwould be enough.typecheck.vim is almost a copy of tslint.vim.