-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting Gradle versions from gradle.properties #1618
Comments
Another option would be to resolve the variable I'm also not sure if this currently works? Does anyone know? |
From my point of view this is one of the most important issues of this bot, so I think this shouldn't be closed. |
I have dependencies like:
So in this case is mandatory to bump lots of dependencies to the same version and not one by one. I understand this problem is difficult to resolve, thank in advance! In the meantime I think is better to hardcode all dependencies to the same version and let dependabot tries to do whatever it wanted to do. Thank for this project 👍 |
@mercuriete I was very pleasantly surprised that this worked! |
Sorry for the noise if this is offtopic @ashughes what do you mean about "this worked"? The problem is dependabot is not intelligent enough to search def variables and create a PR with my example. If you mean the workaround that I proposed... I didn't test it yet. I am not sure that dependabot is working with hardcoded versions per each line I dont want to change my master branch to do that test, probably I will end up doing a test on an copy of my repository. Thanks to the dependabot team for the amazing work. |
@mercuriete I wasn't sure whether or not you were suggesting this as working, but I tried it and it did work, so I assumed you were. 😛 I have 3 dependencies that all use the same version, but they each specified the version individually:
Dependabot created 3 PRs to change each of these individually. After reading your comment I changed the above to the following on my main branch:
Then Dependabot closed all 3 of the previous PRs and opened a new one that just changed Basically, doing this appears to be a great workaround for #1296. |
@ashughes thanks for the clarification I need to investigate more, because that is what is not working for me. |
@ashughes build.gradle on root folder
build.gradle on app folder
and it started to work. Thanks to all the people involved in this issue. |
There is an open issue in dependabot-core [1]. So this serves as a workaround until this issue is fixed. [1] dependabot/dependabot-core#1618
Any updates on this? I also define my versions in |
We do not want dependabot to update the dependencies of test projects. As there is no option to disable dependabot for a directory, enable it only for the where we want it to run. Note that we do not enable dependabot for Gradle because it does not support defining versios in gradle.propertes [1] and we manually check for Gradle dependency updates using the `dependencyUpdates` Gradle task on a regular basis. [1] dependabot/dependabot-core#1618 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
We do not want dependabot to update the dependencies of test projects. As there is no option to disable dependabot for a directory, enable it only for the projects where we want it to run. Note that we do not enable dependabot for Gradle because it does not support defining versios in gradle.propertes [1] and we manually check for Gradle dependency updates using the `dependencyUpdates` Gradle task on a regular basis. [1] dependabot/dependabot-core#1618 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
IMO the only sane way to address this is by implementing: |
We do not want dependabot to update the dependencies of test projects. As there is no option to disable dependabot for a directory, enable it only for the projects where we want it to run. Note that we do not enable dependabot for Gradle because it does not support defining versions in gradle.propertes [1] and we manually check for Gradle dependency updates using the `dependencyUpdates` Gradle task on a regular basis. [1] dependabot/dependabot-core#1618 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
We do not want dependabot to update the dependencies of test projects. As there is no option to disable dependabot for a directory, enable it only for the projects where we want it to run. Note that we do not enable dependabot for Gradle because it does not support defining versions in gradle.propertes [1] and we manually check for Gradle dependency updates using the `dependencyUpdates` Gradle task on a regular basis. [1] dependabot/dependabot-core#1618 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
I have versions defined as below:
and dependencies :
and it didn't bump kotlin to 1.5.10 |
@cricketsamya I'm giving that a try, thanks! The url markdown was malformed, though. https://www.sameerkulkarni.de/posts/dependabot-with-gradle/ is the link. After updating, I ran dependabot and got this error, though the logs seem to indicate all is well (and up to date)
Might need to wait until the next kotlin or spring release to see if it works or broke things for my project. |
@patkujawa-wf sorry for the link! If possible just downgrade one of the dependencies and run dependabot again to see the results. |
Just saw it work with Kotlin 1.6.0! Thanks again for the tip. |
For anyone curious, this gives 404 now. |
Thanks for sharing this, but IMHO this should be addressed by Dependabot. |
Hi, what is the status of this - is Dependabot's plan to address reading from |
*Issue #, if available:* - Some of our dependencies need to be kept in sync (hadoop/spark/freefair/etc). Dependabot doesn't update more than one at a time unless the version is parameterized. *Description of changes:* - Consolidates `gradle.build` file similarities - Migrates versions that are coupled to parameters - Based on behavior mentioned in the comments here: dependabot/dependabot-core#1618 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Dependabot doesn't know how to update variables. See dependabot/dependabot-core#1618
This should make Dependabot group dependency updates to the Jackson libraries, as suggested here: dependabot/dependabot-core#1618 (comment)
) * Bump com.fasterxml.jackson.core:jackson-core from 2.17.0 to 2.17.1 Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.17.0 to 2.17.1. - [Commits](FasterXML/jackson-core@jackson-core-2.17.0...jackson-core-2.17.1) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Group version updates for jackson libraries This should make Dependabot group dependency updates to the Jackson libraries, as suggested here: dependabot/dependabot-core#1618 (comment) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
My
build.gradle
has dependencies like:The variable
assertJVersion
is resolved from thegradle.properties
file.Is there a way to configure the bot to resolve the version from this file?
The text was updated successfully, but these errors were encountered: