Fix Poetry unreachable git deps error #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python-poetry/poetry-core#202 poetry now uses a slightly different (safer) git command, and this caused the regex matching we do on the error output to now fail. This fixes up the regex, and just to be safe ensures it'll keep working with the old version as well. The test that was failing was: `python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb:179`
brrygrdn
approved these changes
Oct 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python-poetry/poetry-core#202 poetry now
uses a slightly different (safer) git command, and this caused the
regex matching we do on the error output to now fail.
This fixes up the regex, and just to be safe ensures it'll keep working
with the old version as well.
The test that was failing was:
python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb:179