deploy from a fork using a workflow #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It errors with: "fatal: refusing to merge unrelated histories"
Nishnha
reviewed
Sep 9, 2022
Nishnha
reviewed
Sep 9, 2022
Nishnha
reviewed
Sep 9, 2022
| docker build \ | ||
| -t "$UPDATER_IMAGE:$TAG" \ | ||
| --build-arg BUILDKIT_INLINE_CACHE=1 \ | ||
| --cache-from "$BASE_IMAGE" \ |
There was a problem hiding this comment.
cache from ubuntu:20.04 seems a bit strange. Any reason we include this line?
There was a problem hiding this comment.
Yeah I agree, I copied this from another workflow.
Nishnha
reviewed
Sep 9, 2022
Nishnha
reviewed
Sep 9, 2022
Nishnha
approved these changes
Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fork PRs can only get read access from GITHUB_TOKEN, we can't use the
docker-branch-releases.ymlworkflow to deploy a fork to GHCR before merging it.This works around that with a manually dispatched workflow that pulls in the PR code, builds, and deploys it. Since it was kicked off by the team it should have the correct permissions.