allow targetarch to be set by Docker buildkit #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
commented
Jan 30, 2023
| @@ -1,7 +1,5 @@ | |||
| FROM ubuntu:20.04 as builder | |||
|
|
|||
| ARG TARGETARCH=amd64 | |||
There was a problem hiding this comment.
This wasn't used in this file so I removed it.
|
Could this close out #5536? |
|
@Nishnha no we still will need to add a workflow to build and publish for ARM to do that. This is just to clean up the scripts a bit. Also I had reverted some changes @jeffwidman had done in #6502 and while researching it a bit more realized we don't have to set that value at all. |
jeffwidman
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Docker docs, we shouldn't have to set the TARGETARCH if we simply declare it in the Dockerfiles as
ARG TARGETARCHwhen using Docker buildkit.This simplifies things a bit and allows any other architectures that our scripts don't explicitly handle to build the containers.
I tested this on my ARM machine and it works.