Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pip-tools 6.12.3 #6757

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Allow pip-tools 6.12.3 #6757

merged 1 commit into from
Mar 1, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Mar 1, 2023

It contains a fix relevant for us that will allow us to update lockfiles uses as constraints in other manifest files.

Switching back to <=, since Dependabot now won't change it back again to < after the fix introduced by #6671.

Closes #6550.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner March 1, 2023 12:12
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

I personally would have gone with the Dependabot PR because it's automated PR/commit messages include direct links to changelog etc which make life quicker down the road for anyone wanting to look that up.

@deivid-rodriguez
Copy link
Contributor Author

I went with a separate PR because I was going to edit the diff anyways to go back to <=, and the only relevant change in the release I was manually linking to it anyways.

It contains a fix relevant for us that will allow us to update lockfiles
uses as constraints in other manifest files.
@jeffwidman jeffwidman enabled auto-merge (squash) March 1, 2023 20:36
@jeffwidman jeffwidman merged commit 6ee17f3 into main Mar 1, 2023
@jeffwidman jeffwidman deleted the deivid-rodriguez/6550 branch March 1, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants