-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Package Bumps #10
[CHORE] Package Bumps #10
Conversation
@@ -10,6 +10,7 @@ module.exports = transpileModules( | |||
}, | |||
webpack: (config) => { | |||
config.experiments = { | |||
...config.experiments, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that overwriting the experiments object was blowing away some of Next's optimizations under the hood and causing errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
After running this locally, I do get some changes in my Edit: Also get the changes with Node v16 and npm v7. |
@smonn I'll sync with you tomorrow before merging this. I'm puzzled why our package-locks are in flux. |
Well I'm definitely waiting for this to be merged before forking/cloning. |
@jakerainis @smonn are you guys are running different versions of node/npm? |
@jakerainis you might want to update the engines directive in package.json to specify node 16 |
We probably were, but will can lock it to Node v16+ and npm v7+. |
If you do, make sure you get the readme as well. (btw, the only reason I mentioned 16 is that Dallas mentioned it) I have no strong preference on which version, just that the engines directive should be more specific (although there's always a good chance this will break CI) |
--oh, and .nvmrc |
Opening this PR to to A) prevent someone else from having to do and 2) testing out the upstream setup from a forked repo.
This PR updates all1 outdated packages. Most of these packages are patches and minor bumps but there are a couple of bigger ones:
Given the nature of all these updates, please do pull it down and play for a few minutes before approving.
Footnotes
All packages with the exception of Pino and ESLint (which I believe are both in the same situation where another dependency we use hasn't been updated to support their latest major versions). ↩