Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Package Bumps #10

Merged

Conversation

jakerainis
Copy link
Contributor

@jakerainis jakerainis commented Nov 1, 2021

Opening this PR to to A) prevent someone else from having to do and 2) testing out the upstream setup from a forked repo.

This PR updates all1 outdated packages. Most of these packages are patches and minor bumps but there are a couple of bigger ones:

  • Next v12 🎉
  • Directus RC100 (the price field didn't seem to break this time 👍 )

Given the nature of all these updates, please do pull it down and play for a few minutes before approving.

Footnotes

  1. All packages with the exception of Pino and ESLint (which I believe are both in the same situation where another dependency we use hasn't been updated to support their latest major versions).

@jakerainis jakerainis added the dependencies Package dependencies label Nov 1, 2021
@@ -10,6 +10,7 @@ module.exports = transpileModules(
},
webpack: (config) => {
config.experiments = {
...config.experiments,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that overwriting the experiments object was blowing away some of Next's optimizations under the hood and causing errors.

Copy link
Contributor

@smonn smonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Contributor

@IanPirro IanPirro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@smonn
Copy link
Contributor

smonn commented Nov 2, 2021

After running this locally, I do get some changes in my package-lock.json. I'm on Node v16 and npm v8. Everything seems to run fine though!

Edit: Also get the changes with Node v16 and npm v7.

@jakerainis
Copy link
Contributor Author

@smonn I'll sync with you tomorrow before merging this. I'm puzzled why our package-locks are in flux.

@afraser
Copy link
Contributor

afraser commented Nov 2, 2021

Well I'm definitely waiting for this to be merged before forking/cloning.

@afraser
Copy link
Contributor

afraser commented Nov 2, 2021

@jakerainis @smonn are you guys are running different versions of node/npm?

@afraser
Copy link
Contributor

afraser commented Nov 2, 2021

@jakerainis you might want to update the engines directive in package.json to specify node 16

@jakerainis
Copy link
Contributor Author

@smonn I just pushed a new lock using node 16 and npm 7. To @afraser's point, do you want me to bump the node version directives in the package.json files?

@smonn
Copy link
Contributor

smonn commented Nov 2, 2021

are you guys are running different versions of node/npm?

We probably were, but will can lock it to Node v16+ and npm v7+.

@afraser
Copy link
Contributor

afraser commented Nov 2, 2021

If you do, make sure you get the readme as well. (btw, the only reason I mentioned 16 is that Dallas mentioned it) I have no strong preference on which version, just that the engines directive should be more specific (although there's always a good chance this will break CI)

@afraser
Copy link
Contributor

afraser commented Nov 2, 2021

--oh, and .nvmrc

@jakerainis
Copy link
Contributor Author

@afraser @smonn 60aa86f

I bumped the directives, regen'd the lock file, and updated the docs (🙏 @afraser).

The .nvmrc is at lts so I think that should be okay for the next 2 years.

@jakerainis jakerainis merged commit e551a3e into deptagency:main Nov 2, 2021
@jakerainis jakerainis deleted the jakerainis/chore_package-upgrades branch November 2, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants