Batch upgrade minor and patch dependencies #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smonn
commented
Jan 21, 2022
| @@ -29,7 +29,7 @@ export const logger = pino({ | |||
| }) | |||
|
|
|||
| export const loggerHttp = http({ | |||
| logger, | |||
| logger: logger as Logger, | |||
There was a problem hiding this comment.
Some weird type incompatibility going on here. Still logs just fine.
jakerainis
approved these changes
Jan 21, 2022
dallashuggins
approved these changes
Jan 21, 2022
|
@smonn Oops, almost missed that the package-lock.json was regenerated for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As always, please try this locally and verify that the package-lock.json file does not change on your end. Let me know!