Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #386

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Upgrade dependencies #386

merged 4 commits into from
Mar 29, 2022

Conversation

smonn
Copy link
Contributor

@smonn smonn commented Mar 29, 2022

Also regenerated package-lock.json and added some more files/patterns to .dockerignore

@smonn
Upgrade dependencies
a5d1d58 
Also regenerated package-lock.json and added some more files/patterns to .dockerignore
@smonn smonn requested a review from a team March 29, 2022 14:04
@smonn smonn self-assigned this Mar 29, 2022
dallashuggins
dallashuggins reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dallashuggins dallashuggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well for me starting the application, etc., but a new package-lock.json file gets generated when installing dependencies.

dallashuggins
dallashuggins approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dallashuggins dallashuggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Thanks for tackling 🙌

@smonn smonn merged commit b030c22 into main Mar 29, 2022
@smonn smonn deleted the smonn/upgrade-deps branch March 29, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallashuggins dallashuggins dallashuggins approved these changes

Assignees

@smonn smonn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smonn @dallashuggins