-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: downgrade lerna to resolve ESM requirement #1098
Conversation
package.json
Outdated
@@ -22,7 +22,7 @@ | |||
"eslint-plugin-prettier": "^5.1.3", | |||
"globals": "^15.2.0", | |||
"husky": "^9.0.10", | |||
"lerna": "^8.0.1", | |||
"lerna": "^8.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended? We're not downgrading here 👀
"version": "8.1.5", | ||
"resolved": "https://registry.npmjs.org/@lerna/create/-/create-8.1.5.tgz", | ||
"integrity": "sha512-Ku8yTGgeumayvMr8sml72EPb6WaoJhRjMTkMZrKSJtcLNDBlDpKwyUxDxNTBNBRUYWUuJCnj7eUH7pDNuc9odQ==", | ||
"version": "8.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zidious sorry the downgrade existed in the lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah missed that! Should be pin Lerna then to 8.1.3? Dependabot will update this next time around to >8.1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call just updated and pinned to 8.1.3
@@ -22,7 +22,7 @@ | |||
"eslint-plugin-prettier": "^5.1.3", | |||
"globals": "^15.2.0", | |||
"husky": "^9.0.10", | |||
"lerna": "^8.0.1", | |||
"lerna": "8.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to add it to the dependabot.yml
too
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@axe-core/playwright](https://togithub.com/dequelabs/axe-core-npm) | [`4.9.1` -> `4.10.0`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.1/4.10.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dequelabs/axe-core-npm (@​axe-core/playwright)</summary> ### [`v4.10.0`](https://togithub.com/dequelabs/axe-core-npm/releases/tag/v4.10.0): Release 4.10.0 [Compare Source](https://togithub.com/dequelabs/axe-core-npm/compare/v4.9.1...v4.10.0) #### What's Changed - fix(playwright): Add missing await on page.evaluate by [@​KuSh](https://togithub.com/KuSh) in [dequelabs/axe-core-npm#1063 - chore: update to support eslint 9 flat config by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1064 - chore: merge master into develop by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [dequelabs/axe-core-npm#1071 - chore: bump puppeteer from 21.7.0 to 22.10.0 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1073 - chore: bump sinon from 17.0.1 to 18.0.0 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1076 - chore: bump chromedriver from 121.0.0 to 125.0.3 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1075 - chore: fix eslint errors and warnings by [@​straker](https://togithub.com/straker) in [dequelabs/axe-core-npm#1079 - chore: bump typescript-eslint from 8.0.0-alpha.12 to 8.0.0-alpha.26 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1078 - chore: bump the npm-low-risk group across 1 directory with 22 updates by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1077 - chore: use updated browser-driver-manager by [@​scottmries](https://togithub.com/scottmries) in [dequelabs/axe-core-npm#1080 - chore: bump the npm-low-risk group with 27 updates by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1081 - chore: bump chromedriver from 125.0.3 to 126.0.4 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1082 - feat: Update axe-core to v4.10.0 by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [dequelabs/axe-core-npm#1088 - chore: downgrade lerna to resolve ESM requirement by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1098 - fix(cli): include `dotenv` dep by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1103 - chore: RC v4.10.0 by [@​github-actions](https://togithub.com/github-actions) in [dequelabs/axe-core-npm#1108 - Release 4.10.0 by [@​dequejenn](https://togithub.com/dequejenn) in [dequelabs/axe-core-npm#1110 #### New Contributors - [@​KuSh](https://togithub.com/KuSh) made their first contribution in [dequelabs/axe-core-npm#1063 **Full Changelog**: dequelabs/axe-core-npm@v4.9.1...v4.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/camunda/camunda). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@axe-core/playwright](https://togithub.com/dequelabs/axe-core-npm) | [`^4.9.1` -> `^4.10.0`](https://renovatebot.com/diffs/npm/@axe-core%2fplaywright/4.9.1/4.10.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@axe-core%2fplaywright/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@axe-core%2fplaywright/4.9.1/4.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/microsoft/playwright)) | [`^1.46.0` -> `^1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.46.0/1.46.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@playwright%2ftest/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@playwright%2ftest/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@playwright%2ftest/1.46.0/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@playwright%2ftest/1.46.0/1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | mcr.microsoft.com/playwright | `v1.46.0` -> `v1.46.1` | [![age](https://developer.mend.io/api/mc/badges/age/docker/mcr.microsoft.com%2fplaywright/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/mcr.microsoft.com%2fplaywright/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/mcr.microsoft.com%2fplaywright/v1.46.0/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/mcr.microsoft.com%2fplaywright/v1.46.0/v1.46.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | final | patch | --- ### Release Notes <details> <summary>dequelabs/axe-core-npm (@​axe-core/playwright)</summary> ### [`v4.10.0`](https://togithub.com/dequelabs/axe-core-npm/releases/tag/v4.10.0): Release 4.10.0 [Compare Source](https://togithub.com/dequelabs/axe-core-npm/compare/v4.9.1...v4.10.0) #### What's Changed - fix(playwright): Add missing await on page.evaluate by [@​KuSh](https://togithub.com/KuSh) in [dequelabs/axe-core-npm#1063 - chore: update to support eslint 9 flat config by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1064 - chore: merge master into develop by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [dequelabs/axe-core-npm#1071 - chore: bump puppeteer from 21.7.0 to 22.10.0 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1073 - chore: bump sinon from 17.0.1 to 18.0.0 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1076 - chore: bump chromedriver from 121.0.0 to 125.0.3 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1075 - chore: fix eslint errors and warnings by [@​straker](https://togithub.com/straker) in [dequelabs/axe-core-npm#1079 - chore: bump typescript-eslint from 8.0.0-alpha.12 to 8.0.0-alpha.26 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1078 - chore: bump the npm-low-risk group across 1 directory with 22 updates by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1077 - chore: use updated browser-driver-manager by [@​scottmries](https://togithub.com/scottmries) in [dequelabs/axe-core-npm#1080 - chore: bump the npm-low-risk group with 27 updates by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1081 - chore: bump chromedriver from 125.0.3 to 126.0.4 by [@​dependabot](https://togithub.com/dependabot) in [dequelabs/axe-core-npm#1082 - feat: Update axe-core to v4.10.0 by [@​attest-team-ci](https://togithub.com/attest-team-ci) in [dequelabs/axe-core-npm#1088 - chore: downgrade lerna to resolve ESM requirement by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1098 - fix(cli): include `dotenv` dep by [@​michael-siek](https://togithub.com/michael-siek) in [dequelabs/axe-core-npm#1103 - chore: RC v4.10.0 by [@​github-actions](https://togithub.com/github-actions) in [dequelabs/axe-core-npm#1108 - Release 4.10.0 by [@​dequejenn](https://togithub.com/dequejenn) in [dequelabs/axe-core-npm#1110 #### New Contributors - [@​KuSh](https://togithub.com/KuSh) made their first contribution in [dequelabs/axe-core-npm#1063 **Full Changelog**: dequelabs/axe-core-npm@v4.9.1...v4.10.0 </details> <details> <summary>microsoft/playwright (@​playwright/test)</summary> ### [`v1.46.1`](https://togithub.com/microsoft/playwright/compare/v1.46.0...e1c861cfa7a6caf3c5b798786b1e6298c4f3cf31) [Compare Source](https://togithub.com/microsoft/playwright/compare/v1.46.0...v1.46.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
no qa required