fix: only set allowedOrigin when needed #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Sep 21, 2022
packages/playwright/src/index.ts
Outdated
| branding: { application: 'playwright' } | ||
| }) | ||
| `; | ||
| private async script(): Promise<string> { |
There was a problem hiding this comment.
Why is this async? It just returns the string
|
|
||
| it('should not set when running legacy source and legacy mode', async () => { | ||
| await page.goto(`${addr}/index.html`); | ||
| await new AxePuppeteer(page, axeSource + axeForceLegacy) |
There was a problem hiding this comment.
Odd, doesn't look like this file ever makes the legacy source available outside of the without run partial describe.
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Sep 21, 2022
Zidious
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.