Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable esm import #713

Merged
merged 8 commits into from
Apr 28, 2023
Merged

feat: enable esm import #713

merged 8 commits into from
Apr 28, 2023

Conversation

AdnoC
Copy link
Contributor

@AdnoC AdnoC commented Apr 27, 2023

#660

Required some funkiness to make default import work with require, but I think its a clean solution.

@AdnoC AdnoC requested a review from a team as a code owner April 27, 2023 19:36
@AdnoC AdnoC marked this pull request as draft April 27, 2023 19:36
@AdnoC AdnoC marked this pull request as ready for review April 27, 2023 20:50
@AdnoC AdnoC marked this pull request as draft April 27, 2023 20:55
@AdnoC AdnoC marked this pull request as ready for review April 27, 2023 22:18
Zidious
Zidious previously requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things inline -

packages/playwright/src/index.ts Show resolved Hide resolved
packages/playwright/tests/axe-playwright.spec.ts Show resolved Hide resolved
packages/puppeteer/esmTest.mjs Show resolved Hide resolved
@AdnoC AdnoC dismissed Zidious’s stale review April 28, 2023 17:31

resolved questions

Zidious
Zidious approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ☕

Not blocking - "Closes: XXX" rather than just the ticket

@AdnoC AdnoC merged commit 076bfa9 into develop Apr 28, 2023
@AdnoC AdnoC deleted the feat-esm branch April 28, 2023 17:34
@dequejenn dequejenn mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidious Zidious Zidious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdnoC @Zidious