Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ensure packages are built #854

Merged
merged 8 commits into from
Oct 4, 2023
Merged

ci: ensure packages are built #854

merged 8 commits into from
Oct 4, 2023

Conversation

michael-siek
Copy link
Member

No description provided.

@michael-siek michael-siek marked this pull request as ready for review October 4, 2023 00:49
@michael-siek michael-siek requested a review from a team as a code owner October 4, 2023 00:49
Zidious
Zidious previously requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments inline -

package.json Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
@michael-siek michael-siek enabled auto-merge (squash) October 4, 2023 01:20
@michael-siek michael-siek merged commit 790824d into develop Oct 4, 2023
26 checks passed
@michael-siek michael-siek deleted the build/packages branch October 4, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidious Zidious Zidious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @Zidious