Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oci registry impl] Support az acr login -n <REGISTRY> #444

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Mar 14, 2023

ref: #434

Use the identitytoken added to the standard ~/.docker/config.json by some tools

Notably, the result of az acr login -n <REGISTRY> command writes the identitytoken property, which is expected to be used as a refresh_token. See the following capture from how oras performs this exchange.

image

This may be more useful generally, but the only registry we've encountered that expects this is the Azure Container Registry.

Below demonstrates fetching a Feature's manifest by using the auth outputted by az acr login.

image

In an example project:
image

@joshspicer joshspicer changed the title support exchanging identitytoken (refresh_token) in container registr… [oci registry impl] Support az acr login -n <REGISTRY> Mar 14, 2023
@joshspicer joshspicer marked this pull request as ready for review March 14, 2023 00:56
@joshspicer joshspicer requested a review from a team as a code owner March 14, 2023 00:56
@joshspicer joshspicer self-assigned this Mar 14, 2023
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joshspicer joshspicer merged commit 4d5a0f2 into main Mar 14, 2023
@joshspicer joshspicer deleted the joshspicer/features/private-azure-cr branch March 14, 2023 16:06
joshspicer added a commit that referenced this pull request Mar 14, 2023
joshspicer added a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants