[DO NOT MERGE] sketch AWS Aurora backend #97
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Jul 25, 2023
| schemas = schemas or ["public"] | ||
|
|
||
| query = f""" | ||
| SELECT {tipg_schema}.tipg_catalog( |
There was a problem hiding this comment.
we use tipg_catalog from a custom schema.
vincentsarago
commented
Jul 25, 2023
| false | ||
| ); | ||
| """ | ||
| ) |
There was a problem hiding this comment.
almost like tipg.database.connection_factory but without SQL registering to the pg_temp schema
vincentsarago
commented
Jul 25, 2023
tipg/backends/aurora/database.py
Outdated
|
|
||
| async with app.state.pool.acquire() as conn: | ||
| rows = await conn.fetch_b(query, schema=tipg_schema) | ||
| assert rows, f"Couldn't file `tipg_catalog` in {tipg_schema}" |
There was a problem hiding this comment.
tipg_catalog function exists in the schema
vincentsarago
commented
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should't be merged and the code produced here might be forwarded to documentation.
This is an example on how to create a tipg backend with functions written to a
tipg_schemainstead ofpg_temp.This code is not tested!