Added support for Swift Package Manager #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Zandor300
requested changes
Jun 25, 2019
There was a problem hiding this comment.
@robcas3 Thanks you so much for your contribution to the DeviceKit library. Thanks for improving the SPM support of the library. Myself and @denisenepraunig aren't really familiar with SPM so this works out nicely. I did however find some things with your changes, please have these sorted out so that we are able to merge this into master.
Thanks again!
.swiftpm/xcode/package.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
Outdated
Show resolved
Hide resolved
Zandor300
reviewed
Jun 25, 2019
Zandor300
requested changes
Jun 25, 2019
Zandor300
requested changes
Jul 16, 2019
Zandor300
approved these changes
Jul 17, 2019
|
@robcas3 Thanks for your contribution! |
|
@Zandor300 You're welcome! |
|
Thank you @robcas3 for your effort! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Swift Package Manager