New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for October 2020 devices #262

Merged

denisenepraunig merged 6 commits into master from october-2020-devices

Oct 21, 2020

Member

Zandor300 commented Oct 13, 2020 •

edited

Loading

Version increase
Update changelog

iPhones

iPhone 12
iPhone 12 mini
iPhone 12 Pro
iPhone 12 Pro Max

Tasks:

Device Identifiers
~~Support Technical Specifications Links~~*
~~Support Images~~*

iPad

iPad Air (4th generation)

Tasks:

Device Identifier
~~Support Technical Specifications Link~~*
~~Support Image~~*

*Support Technical Specs and Image will be added later in favor of an earlier release.


          Add support for all iPhone 12 models and iPad Air (4th generation)

07dbe59

Device identifiers missing for iPhones.
Support link and image missing for iPhones and iPad.

Zandor300 added the enhancement label

Zandor300 added 2 commits

October 14, 2020 00:19


          Bump version to 4.2.0.

b5d7e25


          Update changelog.

5914a9f

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

@@ @@ -148,6 +148,22 @@ public enum Device { @@
                   ///
                   /// ![Image](https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP820/iphone-se-2nd-gen_2x.png)
                   case iPhoneSE2
+                  /// Device is an [iPhone 12](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

@@ @@ -148,6 +148,22 @@ public enum Device { @@
                   ///
                   /// ![Image](https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP820/iphone-se-2nd-gen_2x.png)
                   case iPhoneSE2
+                  /// Device is an [iPhone 12](TODO)
+                  ///
+                  /// ![Image](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  ///
+                  /// ![Image](TODO)
+                  case iPhone12
+                  /// Device is an [iPhone 12 mini](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  case iPhone12
+                  /// Device is an [iPhone 12 mini](TODO)
+                  ///
+                  /// ![Image](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  ///
+                  /// ![Image](TODO)
+                  case iPhone12Mini
+                  /// Device is an [iPhone 12 Pro](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  case iPhone12Mini
+                  /// Device is an [iPhone 12 Pro](TODO)
+                  ///
+                  /// ![Image](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  ///
+                  /// ![Image](TODO)
+                  case iPhone12Pro
+                  /// Device is an [iPhone 12 Pro Max](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

+                  case iPhone12Pro
+                  /// Device is an [iPhone 12 Pro Max](TODO)
+                  ///
+                  /// ![Image](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

@@ @@ -188,6 +204,10 @@ public enum Device { @@
                   ///
                   /// ![Image](https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP822/sp822-ipad-8gen_2x.png)
                   case iPad8
+                  /// Device is an [iPad Air (4th generation)](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot reviewed

View reviewed changes

Source/Device.generated.swift

@@ @@ -188,6 +204,10 @@ public enum Device { @@
                   ///
                   /// ![Image](https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP822/sp822-ipad-8gen_2x.png)
                   case iPad8
+                  /// Device is an [iPad Air (4th generation)](TODO)
+                  ///
+                  /// ![Image](TODO)

devicekit-danger-bot Oct 14, 2020 •

edited

Loading

⚠️	TODOs should be resolved ()).

devicekit-danger-bot commented Oct 14, 2020 •

edited

Loading

	3 Warnings
⚠️	Plist changed, don’t forget to localize your plist values
⚠️	Source/Device.generated.swift#L760 - Prefer non-optional booleans over optional booleans.
⚠️	Source/Device.generated.swift#L1495 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File	Line	Reason
Device.generated.swift	760	Prefer non-optional booleans over optional booleans.
Device.generated.swift	1495	Prefer empty collection over optional collection.
Device.generated.swift	151	TODOs should be resolved ()).
Device.generated.swift	153	TODOs should be resolved ()).
Device.generated.swift	155	TODOs should be resolved ()).
Device.generated.swift	157	TODOs should be resolved ()).
Device.generated.swift	159	TODOs should be resolved ()).
Device.generated.swift	161	TODOs should be resolved ()).
Device.generated.swift	163	TODOs should be resolved ()).
Device.generated.swift	165	TODOs should be resolved ()).
Device.generated.swift	207	TODOs should be resolved ()).
Device.generated.swift	209	TODOs should be resolved ()).

Generated by 🚫 Danger


          Add device identifiers for all iPhone 12.

767864b

denisenepraunig mentioned this pull request

Add the latest Apple released devices like iPhone 12, iPhone 12 mini, Apple Watch Series 6, Apple Watch SE, iPad Air & iPad 8th generation #263

Closed


          Fix Unit tests.

79867c7

denisenepraunig mentioned this pull request

Support 12 Series #264

Closed

Tulleb commented Oct 21, 2020

Xcode 12.1 is out guys! Hope this MR will follow soon 😇
Thank you for the amazing work!


          Update v4.2.0 release date in CHANGELOG.md.

0ec7226

Collaborator

denisenepraunig commented Oct 21, 2020

Xcode 12.1 is out guys! Hope this MR will follow soon 😇
Thank you for the amazing work!

Thanks @Tulleb 😊. You are right. We've been waiting for support images and links and therefore we didn't release yet. We decided to release the technical part (device identifiers) earlier and add the other things when they are available. Should be done today.

AgileFlex commented Oct 21, 2020

Xcode 12.1 is out guys! Hope this MR will follow soon 😇
Thank you for the amazing work!

Thanks @Tulleb 😊. You are right. We've been waiting for support images and links and therefore we didn't release yet. We decided to release the technical part (device identifiers) earlier and add the other things when they are available. Should be done today.

This is great news @denisenepraunig 👏

denisenepraunig approved these changes

View reviewed changes

Collaborator

denisenepraunig left a comment

Thank you @Zandor300 😊👍

denisenepraunig merged commit 8dfc093 into master

denisenepraunig deleted the october-2020-devices branch

October 21, 2020 15:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment