Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key People Section on Home #5

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Add Key People Section on Home #5

merged 5 commits into from
Dec 16, 2021

Conversation

VishalZ123
Copy link
Contributor

Adds key people ( General Secretary Senate and General Secretary ACAC ) on the Home page under the Boards.
Used the OfficeBearerCard component.
key_people

@VishalZ123
Copy link
Contributor Author

@DarshitJain04 I changed the senatefixture.py file

@DarshitJain04
Copy link
Member

Adds key people ( General Secretary Senate and General Secretary ACAC ) on the Home page under the Boards. Used the OfficeBearerCard component. key_people

It seems there is some spacing issue on the home page for these cards (probably for small screen size only). In such cases, it would be better to have 3 or 2 cards in a row?
image

@VishalZ123
Copy link
Contributor Author

It was not the issue of small screen size, it was just rendering a new row of cards just after a card, I have corrected it, now it is similar to the Key People Section of Boards

1

2

3

4

@DarshitJain04

@DarshitJain04 DarshitJain04 merged commit 1b7e480 into devlup-labs:main Dec 16, 2021
RahulGopathi pushed a commit to RahulGopathi/gymkhana-acac that referenced this pull request Jan 5, 2022
fixed issues in responsive display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants