-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL quoting for matrix parameters #409
Conversation
@allburov would appreciate you approving the CI run so I can work on the integration tests 🙏 |
I now realize the integration tests are not run in CI 🤦 I tried to run them locally but without a license key it seems impossible :( I'm not sure how you want to proceed on that. I can make guesses on changes to the integration tests but it seems dangerous to do so. Are you able to run integration and either make the changes in my branch, or show me the warnings/errors and I can try to make changes (this will probably only work if small changes are needed, our back-and-forth will be somewhat slow I think) |
@briantist sorry, I don't have an Artifactory license too right now :( @beliaev-maksim Could you help us with running integration tests for the PR? |
@allburov I also lost access to artifactory.. give me a couple of days. I will try to catch up with some people inside JFrog on the topic of license |
Re: integration tests: of course I would prefer to have coverage in them, but I also don't believe they will be failing right now. I think they will simply show warnings until v0.10.0. If we can get a license that would be great, but if not, I don't think I should modify the tests without someone being able to run them; greater chance that I will break something than help. |
Hi @allburov & @beliaev-maksim just wanted to check in on this |
@allburov |
It affects the actions too #419 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we need to make sure it works with a real Artifactory instance before we merge it. I don't have an instance, if anyone has - please give us a feedback about the changes!
@allburov checked on 7.31.13 - it works! |
@allburov do you have an idea when |
@briantist hi! I'm releasing it on the next Tuesday, 27 June |
Fixes #408
Provides for quoting of matrix parameters to ensure their values (and names) end up in Artifactory correctly, but optionally.
encode_matrix_parameters
with a new required parameterquote_parameters
(I consider this method not really part of the public API)deploy
method will take a parameter of the same name, to pass into the encode functionNone
instead ofFalse
v0.10.0
TODO
s to help find those leading up to the changeTrue
,False
, andNone
(ensure warnings;None
tests should be removed when the default changes)Still left to do: