Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): Styled Dialog Component #852

Merged
merged 3 commits into from
Jul 5, 2024
Merged

feat(client): Styled Dialog Component #852

merged 3 commits into from
Jul 5, 2024

Conversation

hhuolu
Copy link
Contributor

@hhuolu hhuolu commented Jun 23, 2024

  • created component
  • added new dialog for when user is logging out

@hhuolu hhuolu requested review from Rayahhhmed and Shzmj June 23, 2024 08:01
@hhuolu hhuolu requested a review from a team as a code owner June 23, 2024 08:01
Shzmj
Shzmj approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Shzmj Shzmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added comments to Ray's PR re. debugging statements and commented code

@Rayahhhmed Rayahhhmed merged commit 543dbec into dev Jul 5, 2024
3 checks passed
@Rayahhhmed Rayahhhmed deleted the ntgl-accessibility branch July 5, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rayahhhmed Rayahhhmed Rayahhhmed approved these changes

@Shzmj Shzmj Shzmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hhuolu @Rayahhhmed @Shzmj