Remove duplicate params & context args
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rileytomasek
referenced
this pull request
Dec 2, 2023
transitive-bullshit
requested changes
Dec 2, 2023
There was a problem hiding this comment.
Ooooh interesting; I wasn't aware of chatModel.addParams, and given how familiar I am / should be with Dexter, if I wasn't aware of it, then most devs viewing this lib wouldn't have been.
But given that addParams mutates the chat model, we'd ether need to change that to do something like chatModel.extend or clone it first or pass the params as I was doing since I don't think you want a side effect of all uses of the passed chatModel to have a function_call here.
|
Good catch. I will change it to use clone until you get around to transitioning from being mutable to using extend immutably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both already handled statefully by the
ChatModelso we shouldn't beintroducing a second way to accomplish the same thing and more arguments to
support it.
paramsargument