Add telemetry abstraction to remove Sentry dep (round 2) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simplified version of #46. It was easier to copy the important parts and start clean than try and delete all of the generics code. Replace the direct dependency on Sentry with the abstract `Telemetry` interface from @transitive-bullshit. This should have no impact on users who weren't using the Sentry integration, and requires passing Sentry as an argument when creating a model instance. ```ts import { ChatModel } from '@dexaai/dexter' import * as Sentry from '@sentry/node' const model = new ChatModel({ telemetry: Sentry }) ```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rileytomasek
changed the title
rileytomasek
commented
Aug 8, 2024
| cost: 0, | ||
| latency: Date.now() - start, | ||
| }; | ||
| return this.telemetry.startSpan( |
There was a problem hiding this comment.
I also just did s/Sentry/this.telemetry and it made this gnarly diff.
|
@transitive-bullshit i'll merge this when you approve and then master will be in a point where we can make a full |
transitive-bullshit
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of #46. It was easier to copy the important
parts and start clean than try and delete all of the generics code.
Replace the direct dependency on Sentry with the abstract
Telemetryinterface from @transitive-bullshit. This should have no impact on
users who weren't using the Sentry integration, and requires passing
Sentry as an argument when creating a model instance.
I also added an example of using Sentry for tracing.
Example Trace