WIP: Add support for latest openai structured outputs types #48
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if (Msg.isRefusal(lastMessage)) { | ||
| throw new AbortError(lastMessage.refusal); | ||
| } else if (shouldBreakLoop(lastMessage)) { | ||
| const content = await Promise.resolve( | ||
| validateContent(lastMessage.content) | ||
| validateContent(lastMessage.content!) |
There was a problem hiding this comment.
the pattern:
if (Msg.isRefusal(message)) { ... } else { const content = message.content! }
is unfortunately going to be a common one going forwards I think
There was a problem hiding this comment.
Shouldn't Msg.isRefusal() narrow the type to the point where TypeScript knows message.content: string?
There was a problem hiding this comment.
the else block here doesn't guarantee that content exists
| role: 'assistant'; | ||
| name?: string; | ||
| refusal: string; | ||
| }; |
There was a problem hiding this comment.
refusal messages apparently also always have content: null
also, normal assistant messages apparently also always have refusal: null
…IFunction, zodToJsonSchema, and createAIExtractFunction
| @@ -58,7 +58,6 @@ | |||
| "lint": "eslint --cache --cache-location ./node_modules/.cache/eslint .", | |||
| "prebuild": "rimraf dist", | |||
| "predocs": "rimraf docs/pages/docs", | |||
| "prepare": "pnpm run build", | |||
There was a problem hiding this comment.
it's weird to have a pnpm add fail because the build isn't working. I don't think prepare scripts are a good fit for this
| @@ -5,6 +5,7 @@ import { ChatModel } from './chat.js'; | |||
| const FAKE_RESPONSE: Model.Chat.Response = { | |||
| message: { | |||
| content: 'Hi from fake AI', | |||
| refusal: null, | |||
There was a problem hiding this comment.
this is required for the openai types to match up w/ response chat messages
There was a problem hiding this comment.
dexter may live on forever just as a cleanup layer on top of openai's god awful schema design lol
There was a problem hiding this comment.
I need to think a little more about this one because it's doing to have a negative impact on the DX for a relatively small gain.
It might be worth refusing to acknowledge the refusal message type... Don't add it to the Msg family and instead handle refusals by parsing the response and throwing an error if there is a refusal. Then we can handle the (hopefully edge case...) where a refusal is sent without making the DX of these message objects even worse.
PS: I thought OpenAI fired all the tedious people??
|
@transitive-bullshit what do you think of my last comment? |
|
@transitive-bullshit was thinking more about this... what do you think of creating a custom error for refusals and throwing them as an error? that way we could type the api return type as |
|
@transitive-bullshit #51 handles the update and refusal responses by throwing. if we can make that work, adding a dedicated function for structured output calls should be simple. |
This PR adds support for latest OpenAI's structured outputs release.
openai-fetchto latest major Update ChatMessage type with 'refusal' and 'content' is now optional openai-fetch#46Msg.Refusalmessage typeChatMessagetypes wherecontentandrefusalare both optional and responseChatMessagetypes wherecontentandrefusalare apparently both requiredAIFunctionSpec,createAIFunction, andcreateAIExtractFunctionfor OpenAI's newstrictJSON schema support