fix: workaround for dfinity/candid#273 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a little elbow grease we can even get around `Func`'s limitations. We use `Type::Empty` because args subtype in the opposite direction.
Daniel-Bloom-dfinity
requested review from
ericswanson-dfinity and
chenyan-dfinity
Daniel-Bloom-dfinity
added a commit
to Daniel-Bloom-dfinity/examples
that referenced
this pull request
Mar 17, 2022
chenyan-dfinity
approved these changes
Mar 17, 2022
ericswanson-dfinity
approved these changes
Mar 17, 2022
ueldidev0401
pushed a commit
to ueldidev0401/contract-dfinity
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a little elbow grease we can even get around
Func's limitations.Introduces a new type
HttpRequestStreamingCallbackwhich properly serializes/deserializes callbacks of the form:callback : (Token) -> (StreamingCallbackHttpResponse) query;We use
ArgToken(which returnsType::Emptyfromty) for the abstract form, because arguments subtype in the opposite direction so:callback : (Empty) -> (StreamingCallbackHttpResponse<Reserved>) query;Will match without knowing what the
Tokencontents are.