fix: deserialize BlockTree iteratively
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as a draft while I explore a safe alternative in Rust. |
|
I updated the PR with an alternative implementation that doesn't use |
maksymar
approved these changes
Oct 10, 2023
dsarlis
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're now running into a situation where the Bitcoin testnet has ~125k unstable blocks due to a difficulty reset.
Recursively deserializing these blocks, which we do in
post_upgrade, causes a stack overflow.Solution
Rewrite the
BlockTreedeserialization to be iterative rather than recursive. Running a test with the current production state confirms that it fixes that stack overflow issue.