feat: Use the burn cycles API in the Bitcoin canister #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ielashi
reviewed
Nov 20, 2023
canister/src/heartbeat.rs
Outdated
Comment on lines
249
to
256
| let cycles_burnt = 1_000_000; | ||
| with_state_mut(|s| { | ||
| if let Some(metric_cycles_burnt) = &mut s.metrics.cycles_burnt { | ||
| *metric_cycles_burnt += cycles_burnt; | ||
| } else { | ||
| s.metrics.cycles_burnt = Some(cycles_burnt); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Do we need this logic at all? I don't see anywhere where this is being triggered/used.
There was a problem hiding this comment.
I am not sure what you are referring to, but if you think about having optional field - we need an optional field because if it is nonoptional deserialization will fail because we have a new field.
|
@maksymar can you please look at watchdog_helth_status test? The test is failing but I am not sure why. |
|
@ielashi the test is added. |
ielashi
reviewed
Nov 21, 2023
ielashi
approved these changes
Nov 22, 2023
| })" | ||
|
|
||
| # Check that cycles are burnt. | ||
| if [ "$(get_balance)" != "0" ]; then |
There was a problem hiding this comment.
Maybe it'd be more robust to sleep here for a few seconds before calling get balance. Otherwise, it's possible to execute this call before the first heartbeat of the canister runs.
ielashi
reviewed
Nov 22, 2023
Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
dragoljub-duric
deleted the
EXC-1505-use-the-burn-cycles-api-in-the-bitcoin-canister
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.