Support 128-bit system API for cycles #54
Conversation
| CARGO_TARGET_WASM32_UNKNOWN_UNKNOWN_LINKER = "${nixpkgs.llvmPackages_11.lld}/bin/lld"; | ||
| RUSTFLAGS = "-C link-arg=-s"; # much smaller wasm | ||
| CARGO_TARGET_WASM32_UNKNOWN_UNKNOWN_LINKER = "${nixpkgs.llvmPackages_12.lld}/bin/lld"; | ||
| RUSTFLAGS = "-C link-arg=-s -C target-feature=+multivalue"; # much smaller wasm |
There was a problem hiding this comment.
I’m surprised this work, given rust-lang/rust#73755, but 🤷🏻 :-)
There was a problem hiding this comment.
I was quite surprised too, when I found it working. I gave it a go and I did not regret. :)
However, there is one last problem. Even though the produced WASM is correct, the compiler spits out following warnings: "warning: extern block uses type (u64, u64), which is not FFI-safe". We can mitigate this at a price of obfuscating types by using a tuple struct, i.e. Pair(u64, u64). More radical option is to disable the troublesome check. What do you think?
There was a problem hiding this comment.
For ic-ref-test, I have no strong opinions. If using a tuple struct works, go head – what matters is what happens on the Wasm level.
|
Thanks for the review, @nomeata! |
No description provided.