fix: integer overflow in NNS tests in is_inactive
#1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests, `now` may be set to less than 2 weeks. It was observed to be set to something between 50 and 60 seconds. This caused an overflow. This was discovered using TLA codelink.
andrew-lee-work
changed the title
is_inactive is_inactive
aterga
approved these changes
Oct 11, 2024
max-dfinity
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests,
nowwas observed to be set to something between 50 and 60 seconds. Whennowis set to less than 2 weeks, an integer overflow is triggered, which can cause the neuron to be incorrectly recognized as inactive. This happened during testing ofclaim_neuron.This should not affect prod because in prod,
nowshould always be much larger than 2 weeks.This was discovered using TLA codelink.