fix(PocketIC): retry topology operation if the instance is busy #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxgst
reviewed
Oct 11, 2024
| @@ -994,6 +994,10 @@ impl Operation for GetTopology { | |||
| OpOut::Topology(pic.topology().clone()) | |||
| } | |||
|
|
|||
| fn retry_if_busy(&self) -> bool { | |||
There was a problem hiding this comment.
Who would call that function? I don't understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the PocketIC operation to fetch topology is also expected to be called by IC agents that don't expect to retry the operation if the PocketIC instance is busy, we need to retry in PocketIC.