Skip to content

Commit

Permalink
Remove interface check breaking change exception (#2640)
Browse files Browse the repository at this point in the history
This PR removes the breaking change exception from the CI interface
compatibility check. The exception is no longer necessary as the
breaking changes have been released.
  • Loading branch information
frederikrothenberger authored Oct 3, 2024
1 parent 34c1321 commit 36179e8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 136 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -954,23 +954,8 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-didc
- name: 'Get latest release'
uses: actions/github-script@v7
id: latest-release-tag
with:
result-encoding: string
script: return (await github.rest.repos.getLatestRelease({owner:"dfinity", repo:"internet-identity"})).data.tag_name;
- name: "Check canister interface compatibility"
run: |
release="release-2024-09-17"
# undo the breaking changes that we _explicitly_ made
# remove after the next release
# if we accidentally introduced other breaking changes, the patch would no longer apply / fix them
# making this job fail.
if [ "${{ steps.latest-release-tag.outputs.result }}" == "$release" ]; then
echo "Rolling back intentionally made breaking changes $release"
git apply allowed_breaking_change.patch
fi
curl -sSL https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did -o internet_identity_previous.did
didc check src/internet_identity/internet_identity.did internet_identity_previous.did
Expand Down
121 changes: 0 additions & 121 deletions allowed_breaking_change.patch

This file was deleted.

0 comments on commit 36179e8

Please sign in to comment.