Implement review feedback

dfinity · Oct 2, 2024 · e8c0ada · e8c0ada
1 parent 094381b
commit e8c0ada
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/internet_identity/src/anchor_management/registration/registration_flow_v2.rs b/src/internet_identity/src/anchor_management/registration/registration_flow_v2.rs
@@ -52,10 +52,11 @@ pub async fn identity_registration_start() -> Result<IdRegNextStepResult, IdRegS
         return Err(IdRegStartError::InvalidCaller);
     }
 
+    let now = time();
     let flow_state = match captcha_required() {
-        true => captcha_flow_state(time()).await.1,
+        true => captcha_flow_state(now).await.1,
         false => RegistrationFlowState::FinishRegistration {
-            flow_created_timestamp_ns: time(),
+            flow_created_timestamp_ns: now,
         },
     };
 

diff --git a/src/internet_identity/tests/integration/v2_api/identity_register/dynamic_captcha.rs b/src/internet_identity/tests/integration/v2_api/identity_register/dynamic_captcha.rs
@@ -42,8 +42,8 @@ fn should_require_captcha_above_threshold_rate() {
 
     // Double the rate of registrations to one per second
     // The 20% threshold rate should allow 5 registrations before the captcha kicks in
-    let flow_principal = test_principal(0);
-    for _ in 0..5 {
+    for i in 0..5 {
+        let flow_principal = test_principal(i);
         let result = api_v2::identity_registration_start(&env, canister_id, flow_principal)
             .expect("API call failed")
             .expect("registration start failed");
@@ -56,7 +56,7 @@ fn should_require_captcha_above_threshold_rate() {
         env.advance_time(Duration::from_secs(1));
     }
 
-    let result = api_v2::identity_registration_start(&env, canister_id, flow_principal)
+    let result = api_v2::identity_registration_start(&env, canister_id, test_principal(99))
         .expect("API call failed")
         .expect("registration start failed");