Add main window with sidebar component and css #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Can I put this in the authenticateBox.ts module or nearby? There's not need to make this a general "component" if we don't use this anywhere else. Plus the comments & name are misleading, this isn't really a "main window" "[used] to wrap the content of each page" since we only use it in one page
There was a problem hiding this comment.
yes of course. Let me know if I should look into that
nmattia
reviewed
Jun 28, 2023
| fill="none" | ||
| viewBox="0 0 233 111" | ||
| > | ||
| <defs> |
There was a problem hiding this comment.
IIRC you're inlining the logo because the IDs cannot be duplicated, can you leave a comment about this?
There was a problem hiding this comment.
exactly. Im adding a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟡 Some screens were changed