Remove dependency on the ic-crypto-standalone-sig-verifier
#2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `ic-crypto-standalone-sig-verifier` dependency, because it was one of the last dependency that II had on the ic repository. There are now properly published alternatives available (also maintained by the crypto team). However, the published package only supports canister signatures at the moment, the feature set of `sig-verifier-js` is reduced to only verifying canister signatures too. This is sufficient to integrate with II in a web2 context (which is what this library was initially intended for).
frederikrothenberger
force-pushed
the
frederik/remove-standalone-sig-verifier
branch
from
8cd338a
to
5dd1d0c
Compare
frederikrothenberger
deleted the
frederik/remove-standalone-sig-verifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ic-crypto-standalone-sig-verifierdependency, because it was one of the last dependency that II had on the ic repository. There are now properly published alternatives available (also maintained by the crypto team).However, the published package only supports canister signatures at the moment, the feature set of
sig-verifier-jsis reduced to only verifying canister signatures too. This is sufficient to integrate with II in a web2 context (which is what this library was initially intended for).🟡 Some screens were changed