Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config endpoint #2602

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add config endpoint #2602

merged 2 commits into from
Sep 11, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Sep 11, 2024 •
edited by github-actions bot
Loading

Adds an endpoint to query the currently active config (i.e. InternetIdentityInit).

🟡 Some screens were changed

@frederikrothenberger frederikrothenberger requested a review from a team as a code owner September 11, 2024 09:47
@frederikrothenberger
Add config endpoint
752235c 
Adds an endpoint to query the currently active config
(i.e. `InternetIdentityInit`).
lmuntaner
lmuntaner approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the InternetIdentityInit is not stored all in one place but multiple ones.

@frederikrothenberger
Copy link
Member Author

Interesting that the InternetIdentityInit is not stored all in one place but multiple ones.

Yeah, that should probably be cleaned up 🙃

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit edd4b57 Sep 11, 2024
66 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/config-endpoint branch September 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikrothenberger @lmuntaner