Allow fractions in helper assert_metric helper
#2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `assert_metric` helper only parses integers right now, even though the metrics could be fractions. This is required once the registrations rates are exposed as a metric, hence this PR to fix it.
lmuntaner
approved these changes
Sep 30, 2024
We will use this in a test in the upcoming registration rate tracking. This is how I found that we don't support it in the first place. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert_metrichelper only parses integers right now, even though the metrics could be fractions.This is required once the registrations rates are exposed as a metric, hence this PR to fix it.