Add script test canisters #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frederikrothenberger please review |
frederikrothenberger
approved these changes
Oct 15, 2024
scripts/test.canisters.sh
Outdated
| # Run tests | ||
|
|
||
| echo "Running integration tests." | ||
| cargo test "${@}" |
There was a problem hiding this comment.
Suggested change
| cargo test "${@}" | |
| cargo test "${@}" | |
scripts/test.canisters.sh
Outdated
| @@ -0,0 +1,49 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This is the only script with multiple dots in the name. What about calling it test-canisters.sh?
There was a problem hiding this comment.
Yes, good point.
scripts/test.canisters.sh
Outdated
| #!/bin/bash | ||
|
|
||
| POCKET_IC_SERVER_VERSION=6.0.0 | ||
| POCKET_IC_SERVER_PATH="pocket-ic" |
There was a problem hiding this comment.
Given you are dealing with paths here, what about making sure that the working directory really is the repository directory?
There was a problem hiding this comment.
We also usually set flags to fail early on error:
set -euo pipefail
There was a problem hiding this comment.
Good idea, done!
scripts/test-canisters.sh
Outdated
| PREVIOUS_ARCHIVE_WASM_PATH="archive_previous.wasm.gz" | ||
|
|
||
| # Check if the script is run from the root of the project | ||
| project_root=$(git rev-parse --show-toplevel 2>/dev/null) |
There was a problem hiding this comment.
We normally just switch to the appropriate directory:
SCRIPTS_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
cd "$SCRIPTS_DIR/.."
There was a problem hiding this comment.
Ah, ok, changed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make it easy to run the canisters tests.
Tu run all the tests successfully, the environment needs to be set up. There was a readme file explaining part of it.
Changes
I moved the explanation to a script that can be run and it will download the necessary artifacts needed to run all the tests.
🟡 Some screens were changed