Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no need to expose port for probes #53

Merged
merged 5 commits into from
Sep 17, 2019
Merged

no need to expose port for probes #53

merged 5 commits into from
Sep 17, 2019

Conversation

NargiT
Copy link
Contributor

@NargiT NargiT commented Sep 4, 2019

I was doing the exercise and there is no need to expose the container port on kubernetes v1.15.1

@NargiT
no need to expose port for probes
8ea9e44 
I was doing the exerice and there is no need to expose the container port on kubernetes v1.15.1
@dgkanatsios
Copy link
Owner

Thanks for your contribution!
I'd rather have a comment there explaining that it is optional, rather than delete it completely. Let's maintain backwards compatibility!

@NargiT
Copy link
Contributor Author

NargiT commented Sep 11, 2019

hopefully it's more clear

dgkanatsios
dgkanatsios reviewed Sep 11, 2019
View reviewed changes
e.observability.md Outdated Show resolved Hide resolved
@dgkanatsios
Copy link
Owner

thanks! minor typo and we can merge!

@NargiT
Copy link
Contributor Author

NargiT commented Sep 17, 2019

done

@dgkanatsios dgkanatsios merged commit 1365338 into dgkanatsios:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgkanatsios dgkanatsios dgkanatsios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NargiT @dgkanatsios