Skip to content

Commit

Permalink
Rename reset to default (helix-editor#8114)
Browse files Browse the repository at this point in the history
Use `default` instead of `reset`, as this is the conventional name for ANSI codes 39/49. The word `reset` should be reserved for ANSI code `0`, which resets both fg and bg colors at once, while also removing all modifiers. While the code uses the value name `Reset`, this is misleading and should not leak into the user space.
  • Loading branch information
chtenb authored and dgkf committed Jan 30, 2024
1 parent d41df19 commit a602092
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion book/src/themes.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ over it and is merged into the default palette.

| Color Name |
| --- |
| `reset` |
| `default` |
| `black` |
| `red` |
| `green` |
Expand Down
2 changes: 1 addition & 1 deletion helix-view/src/theme.rs
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ impl Default for ThemePalette {
fn default() -> Self {
Self {
palette: hashmap! {
"reset".to_string() => Color::Reset,
"default".to_string() => Color::Reset,
"black".to_string() => Color::Black,
"red".to_string() => Color::Red,
"green".to_string() => Color::Green,
Expand Down

0 comments on commit a602092

Please sign in to comment.