Update go.mod to v2 and add v2 import paths. #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
martinmr
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Reviewed 51 of 51 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
There was a problem hiding this comment.
| 1 Message | |
|---|---|
| 📂 | Since this pull request is no longer open, the code review job will remain active in the PullRequest network until you cancel it - or - 48 hours pass with no activity after feedback has been posted. Read More |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged we can cut v2.0.0-rc4 and then do an official v2.0.0 release later.
Once this is merged,
deporgovendorwill NO LONGER WORK with Badger. Please use Go modules.This change is