Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to store usermetadata in lsm #123

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

janardhan1993
Copy link

@janardhan1993 janardhan1993 commented Jul 25, 2017

This change is Reviewable

@manishrjain
Copy link
Contributor

:lgtm:


Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@srh
Copy link

srh commented Jul 25, 2017

Why is the user metadata one byte?


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@janardhan1993
Copy link
Author

1 byte was sufficient for our use case in dgraph. I should have made it more generic, my bad.
I will change the encoding to store the length of usermetadata along with the metadata, so in case the user is not storing anything we will have only 1 byte overhead per key which should be ok.

@srh
Copy link

srh commented Jul 25, 2017

I'm not saying we should make it more generic. I was wondering the reason. We could always make it more generic later.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@srh
Copy link

srh commented Jul 25, 2017

But if we did make it more generic, CAS values could use the same feature and storage overhead per CAS would be optional to the user.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@srh
Copy link

srh commented Jul 25, 2017

Anyway, :lgtm:, we can always make that change separately.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@janardhan1993 janardhan1993 merged commit 835ef24 into master Jul 27, 2017
@janardhan1993 janardhan1993 deleted the feature/user_metadata branch July 27, 2017 00:19
spongedu pushed a commit to spongedu/badger that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants